On Tue, 20 May 2025 at 13:33, Milosz Wasilewski <milosz.wasilewski@foundries.io> wrote:
On Tue, May 20, 2025 at 2:22 AM Chase Qi <chase.qi@linaro.org> wrote:
>
>
>
> On Mon, 19 May 2025 at 19:53, Milosz Wasilewski <milosz.wasilewski@foundries.io> wrote:
>>
>> On Mon, May 19, 2025 at 12:13 PM Chase Qi <chase.qi@linaro.org> wrote:
>> >
>> > Hi Milosz,
>> >
>> > Per the discussion here https://gitlab.com/lava/lava/-/merge_requests/2800#note_2503048170, what about we set the default download retries back to 1? When the retries is increased explicitly, the timeout should be set to 'retries * timeout'. Make sense?
>>
>> This is _a_ solution. What is implemented currently must be changed.
>> The problem with that is that it disables the possibility of setting
>> http-download action timeout separately. It's always going to come
>> from "division" of the parent timeout by the number of repetitions,
>> even if it's dividing by 1.
>
>
> I am not sure what is missing. The named action timeout below works fine for me.
>
> ```
> - deploy:
>     timeout:
>       minutes: 5
>     timeouts:
>       http-download:
>         minutes: 3
>     to: downloads
>     images:
>       boot:
>         url: http://192.168.18.190:8088/db410c/hc/boot-linaro-buster-dragonboard-410c-359.img.gz
>         compression: gz
> ```
>
> Named action timeout always has a priority, and it wouldn't be divided. When a named action is not provided, lava needs to set a timeout for the child actions.

If you define it in job timeouts as:

timeouts:
  actions:
    http-download:
      minutes: 3

It won't work.

This is not related to 2025.02 or the fix for action retries. It won't work with old releases like 2024.09 either, see https://validation.linaro.org/scheduler/job/4149138. IMO, the job level named action timeout should be respected too if it is smaller than its parent action timeout and no action block level named action timeout is provided. MRs are welcome.

Cheers,
Chase
 

Best Regards,
Milosz