On Tue, 30 Apr 2019 at 09:19, Remi Duraffort remi.duraffort@linaro.org wrote:

Hello,

I'm surprised by such change as the corresponding source code hasn't been touched for more than a year. Anyway, I can confirmed that the result strings should be lower case "pass", "fail", "skip" or "unknown".

Isn't this caused by removal of default 'fixup' dictionary? I recall talking about that recently.

milosz

Thanks

Le mer. 24 avr. 2019 à 12:15, Patryk Mungai Ndungu patryk.mungai-ndungu.kx@renesas.com a écrit :

...

Hello,

I have recently upgraded from 2018.11 to 2019.03 and have noticed that the results of a lot of the tests I have been running no longer got parsed correctly by LAVA. This was because I was sending the results using upper case results strings. Eg. lava-test-case <test-case> PASS opposed to lava-test-case <test-case> pass

This resulted in the following logs in the lava job: Received signal: <TESTCASE> TEST_CASE_ID=ETH_T_001 RESULT=PASS Bad test result: PASS

Changing my results parsing script to only send lower case results strings fixed the issue, but was this restriction intended with the upgrade?

Kind Regards, Patryk

---

Lava-users mailing list Lava-users@lists.lavasoftware.org https://lists.lavasoftware.org/mailman/listinfo/lava-users

-- Rémi Duraffort LAVA Team, Linaro _______________________________________________ Lava-users mailing list Lava-users@lists.lavasoftware.org https://lists.lavasoftware.org/mailman/listinfo/lava-users

Hello Remi, Milosz,

Thank you for the explanation. I think it was a useful feature, but its an easy enough fix from the user side as well.

Thanks, Patryk

From: Remi Duraffort remi.duraffort@linaro.org Sent: 30 April 2019 09:32 To: Milosz Wasilewski milosz.wasilewski@linaro.org Cc: Patryk Mungai Ndungu patryk.mungai-ndungu.kx@renesas.com; lava-users@lists.lavasoftware.org Subject: Re: [Lava-users] lava-test-case only handles lower case results strings

Hello Milosz,

you are right, this is due to https://git.lavasoftware.org/lava/lava/commit/b4d84f82fb245ed886c0bcdc7ca421...

I don't think, removing the default fixup dict was needed. Maybe we can reintroduce it if some users needs it.

Cheers

Le mar. 30 avr. 2019 à 10:26, Milosz Wasilewski <milosz.wasilewski@linaro.orgmailto:milosz.wasilewski@linaro.org> a écrit : On Tue, 30 Apr 2019 at 09:19, Remi Duraffort <remi.duraffort@linaro.orgmailto:remi.duraffort@linaro.org> wrote:

Hello,

I'm surprised by such change as the corresponding source code hasn't been touched for more than a year. Anyway, I can confirmed that the result strings should be lower case "pass", "fail", "skip" or "unknown".

Isn't this caused by removal of default 'fixup' dictionary? I recall talking about that recently.

milosz

Thanks

Le mer. 24 avr. 2019 à 12:15, Patryk Mungai Ndungu <patryk.mungai-ndungu.kx@renesas.commailto:patryk.mungai-ndungu.kx@renesas.com> a écrit :

...

Hello,

I have recently upgraded from 2018.11 to 2019.03 and have noticed that the results of a lot of the tests I have been running no longer got parsed correctly by LAVA. This was because I was sending the results using upper case results strings. Eg. lava-test-case <test-case> PASS opposed to lava-test-case <test-case> pass

This resulted in the following logs in the lava job: Received signal: <TESTCASE> TEST_CASE_ID=ETH_T_001 RESULT=PASS Bad test result: PASS

Changing my results parsing script to only send lower case results strings fixed the issue, but was this restriction intended with the upgrade?

Kind Regards, Patryk

---

Lava-users mailing list Lava-users@lists.lavasoftware.orgmailto:Lava-users@lists.lavasoftware.org https://lists.lavasoftware.org/mailman/listinfo/lava-users

-- Rémi Duraffort LAVA Team, Linaro _______________________________________________ Lava-users mailing list Lava-users@lists.lavasoftware.orgmailto:Lava-users@lists.lavasoftware.org https://lists.lavasoftware.org/mailman/listinfo/lava-users

-- Rémi Duraffort LAVA Team, Linaro

Hi Remi,

Great, thank you!

Patryk

From: Remi Duraffort remi.duraffort@linaro.org Sent: 10 June 2019 10:36 To: Patryk Mungai Ndungu patryk.mungai-ndungu.kx@renesas.com Cc: Milosz Wasilewski milosz.wasilewski@linaro.org; lava-users@lists.lavasoftware.org Subject: Re: [Lava-users] lava-test-case only handles lower case results strings

Hello Patryk,

I partially reverted the change to allow to use both upper and lower cases: https://git.lavasoftware.org/lava/lava/merge_requests/588

Should be in the next release (2019.06)

Cheers

Le mar. 30 avr. 2019 à 14:58, Patryk Mungai Ndungu <patryk.mungai-ndungu.kx@renesas.commailto:patryk.mungai-ndungu.kx@renesas.com> a écrit : Hello Remi, Milosz,

Thank you for the explanation. I think it was a useful feature, but its an easy enough fix from the user side as well.

Thanks, Patryk

From: Remi Duraffort <remi.duraffort@linaro.orgmailto:remi.duraffort@linaro.org> Sent: 30 April 2019 09:32 To: Milosz Wasilewski <milosz.wasilewski@linaro.orgmailto:milosz.wasilewski@linaro.org> Cc: Patryk Mungai Ndungu <patryk.mungai-ndungu.kx@renesas.commailto:patryk.mungai-ndungu.kx@renesas.com>; lava-users@lists.lavasoftware.orgmailto:lava-users@lists.lavasoftware.org Subject: Re: [Lava-users] lava-test-case only handles lower case results strings

Hello Milosz,

you are right, this is due to https://git.lavasoftware.org/lava/lava/commit/b4d84f82fb245ed886c0bcdc7ca421...

I don't think, removing the default fixup dict was needed. Maybe we can reintroduce it if some users needs it.

Cheers

Le mar. 30 avr. 2019 à 10:26, Milosz Wasilewski <milosz.wasilewski@linaro.orgmailto:milosz.wasilewski@linaro.org> a écrit : On Tue, 30 Apr 2019 at 09:19, Remi Duraffort <remi.duraffort@linaro.orgmailto:remi.duraffort@linaro.org> wrote:

Hello,

I'm surprised by such change as the corresponding source code hasn't been touched for more than a year. Anyway, I can confirmed that the result strings should be lower case "pass", "fail", "skip" or "unknown".

Isn't this caused by removal of default 'fixup' dictionary? I recall talking about that recently.

milosz

Thanks

Le mer. 24 avr. 2019 à 12:15, Patryk Mungai Ndungu <patryk.mungai-ndungu.kx@renesas.commailto:patryk.mungai-ndungu.kx@renesas.com> a écrit :

...

Hello,

I have recently upgraded from 2018.11 to 2019.03 and have noticed that the results of a lot of the tests I have been running no longer got parsed correctly by LAVA. This was because I was sending the results using upper case results strings. Eg. lava-test-case <test-case> PASS opposed to lava-test-case <test-case> pass

This resulted in the following logs in the lava job: Received signal: <TESTCASE> TEST_CASE_ID=ETH_T_001 RESULT=PASS Bad test result: PASS

Changing my results parsing script to only send lower case results strings fixed the issue, but was this restriction intended with the upgrade?

Kind Regards, Patryk

---

Lava-users mailing list Lava-users@lists.lavasoftware.orgmailto:Lava-users@lists.lavasoftware.org https://lists.lavasoftware.org/mailman/listinfo/lava-users

-- Rémi Duraffort LAVA Team, Linaro _______________________________________________ Lava-users mailing list Lava-users@lists.lavasoftware.orgmailto:Lava-users@lists.lavasoftware.org https://lists.lavasoftware.org/mailman/listinfo/lava-users

-- Rémi Duraffort LAVA Team, Linaro

-- Rémi Duraffort LAVA Team, Linaro