On 26 July 2017 at 12:44, Benjamin Auclair benjamin.auclair@devialet.com wrote:

Hi everyone, hope you're fine ! I'm quite stuck in my platform development: indeed, I succedded in adding my own device type, I'm able to boot on linux by TFTP and to perform auto-login actions. However, I face difficulties with test-shell.

I have the following error:

https://pastebin.com/grPcvb14

You would need to attach the full test job submission.

And the definition of stage is:

https://pastebin.com/ArV11Gbb

Minimal pastes only make sense in a review for a code change. Debugging needs ALL the data.

Stage value seems to be none and I also realized that my test shell isn't downloaded from git during server processing. Thus I think, that stage is empty because the test shell definition isn't in the temporary files. Am I wrong ? Even if I think I found my problem, I don't know how to solve it, may it be due to my device-type config ?

Without seeing the test job submission and the device-type jinja2 it's impossible to tell. Have you modified any code in lava-dispatcher?

Thanks for your answer

Minimal pastes only make sense in a review for a code change. Debugging needs ALL the data.

In fact, I did it because it's just some lava code, you can find the whole code in lava_dispatcher_app folder, in shell.py file at line 240.

Without seeing the test job submission and the device-type jinja2 it's impossible to tell. Have you modified any code in lava-dispatcher?

I didn't modified any code in lava-dispatcher and I attach you in this email my device-type config, test job and full test job submission.

And which version of lava (server and dispatcher) are you running?

2016.12 for both

Thanks and have a nice day !

Benjamin

There is no deploy action defined. The test shell overlay is prepared in the deploy action so that it can be added to the ramdisk or NFS which is to be made available over TFTP.

You need to have a deploy step - what you have currently is that your device.jinja2 only runs bootp, so uses whatever is pre-installed on the device. This is a mistake (see the problems of simplistic testing in the docs https://staging.validation.linaro.org/static/docs/v2/

simple-admin.html#problems-with-simplistic-testing)

So you will need to provide a deploy step including a kernel and a ramdisk and then change the device.jinja2 so that it does a normal deploy action.

Ok got it ! Thanks ! Indeed, I missed this line of documentation about deploy statement:

"Prepare a LAVA overlay tarball containing the test definitions and LAVA API scripts, only if a Test Action Reference action is defined."

Have a nice day

Benjamin

2017-07-27 14:39 GMT+02:00 Neil Williams neil.williams@linaro.org:

On 27 July 2017 at 12:55, Benjamin Auclair benjamin.auclair@devialet.com wrote:

...

Thanks for your answer

...

Minimal pastes only make sense in a review for a code change. Debugging needs ALL the data.

In fact, I did it because it's just some lava code, you can find the

whole

...

code in lava_dispatcher_app folder, in shell.py file at line 240.

...

Without seeing the test job submission and the device-type jinja2 it's impossible to tell. Have you modified any code in lava-dispatcher?

I didn't modified any code in lava-dispatcher and I attach you in this

email

...

my device-type config, test job and full test job submission.

The problem is in the file you've attached called device-job.yaml (which is actually a test job submission - terminology can be important when debugging automation).

There is no deploy action defined. The test shell overlay is prepared in the deploy action so that it can be added to the ramdisk or NFS which is to be made available over TFTP.

You need to have a deploy step - what you have currently is that your device.jinja2 only runs bootp, so uses whatever is pre-installed on the device. This is a mistake (see the problems of simplistic testing in the docs https://staging.validation.linaro.org/static/docs/v2/ simple-admin.html#problems-with-simplistic-testing)

So you will need to provide a deploy step including a kernel and a ramdisk and then change the device.jinja2 so that it does a normal deploy action. Also, don't use the name "device" for things, give it a sensible name that relates to the board itself, something based on the manufacturer, model and/or DTB name.

Do not take shortcuts in adding a new device to LAVA - do a full deploy step and then LAVA will be able to provide the scripts which start the execution of the test.

--

Neil Williams

neil.williams@linaro.org http://www.linux.codehelp.co.uk/