Hi, Milosz,
I fully agree with you that it need take care. But when docker open these parameters to user, they surely face the same problem, but docker let user to decide. I think same thing happened to LAVA, this could be decided by lab admin which docker device or which slave could let user add which more parameters?
You know, for many scenario, it's really not an issue to consider the secure or persist, quick/easy test is the key. Even more, these things could be handled outside of LAVA.
And, if possible to add a more generic option "--extra-options" to "utils/docker.py" will more helpful. Inspired from your handing for android, we may try to put UUU action (https://git.lavasoftware.org/lava/lava/-/blob/master/lava_dispatcher/actions...) in docker just like you did for ADB, but still I haven't found a way to operate UUU in docker without `--privileged`... It doesn't work like `adb`...
I submit a ticket here: https://git.lavasoftware.org/lava/lava/-/issues/415
-----Original Message----- From: Milosz Wasilewski milosz.wasilewski@linaro.org Sent: Monday, June 8, 2020 4:20 PM To: Larry Shen larry.shen@nxp.com Cc: antonio.terceiro@linaro.org; lava-users@lists.lavasoftware.org Subject: Re: [Lava-users] [EXT] Re: docker shell cannot handle adbd.
Caution: EXT Email
On Mon, 8 Jun 2020 at 02:24, Larry Shen larry.shen@nxp.com wrote:
Thanks Antonio for the clarify.
A side question: For docker test shell, if possible add more docker options for user? E.g. bind mount, etc.
A scenario is: If we have some code needed when test, currently, we could just inject it into docker image when do docker build, or when test git clone the code from network. You know docker test shell use `--rm`, means every time, we need to git clone it, or if a small changes we need to build the image. A bind mount there to mount our code may make things easier for us?
I think you should be careful with mounting a local resource. It might lead to problems with persistence. Overall might be useful but should be used with caution. Could you report a ticket in gitlab?
milosz
-----Original Message----- From: Lava-users lava-users-bounces@lists.lavasoftware.org On Behalf Of lava-users-request@lists.lavasoftware.org Sent: Saturday, June 6, 2020 8:00 PM To: lava-users@lists.lavasoftware.org Subject: [EXT] Lava-users Digest, Vol 22, Issue 7
Caution: EXT Email
Send Lava-users mailing list submissions to lava-users@lists.lavasoftware.org
To subscribe or unsubscribe via the World Wide Web, visit https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist s.lavasoftware.org%2Fmailman%2Flistinfo%2Flava-users&data=02%7C01% 7Clarry.shen%40nxp.com%7Ca721328d010d4f6e559208d80b84c9ea%7C686ea1d3bc 2b4c6fa92cd99c5c301635%7C0%7C0%7C637272012232138191&sdata=Y8S%2BQm WD5xDzd7qj%2BrnqXnviDXBgkP61SjasdlBBiqE%3D&reserved=0 or, via email, send a message with subject or body 'help' to lava-users-request@lists.lavasoftware.org
You can reach the person managing the list at lava-users-owner@lists.lavasoftware.org
When replying, please edit your Subject line so it is more specific than "Re: Contents of Lava-users digest..."
Today's Topics:
- Re: [EXT] Re: docker shell cannot handle adbd. (Antonio
Terceiro)
Message: 1 Date: Fri, 5 Jun 2020 09:26:18 -0300 From: Antonio Terceiro antonio.terceiro@linaro.org To: lava-users@lists.lavasoftware.org Subject: Re: [Lava-users] [EXT] Re: docker shell cannot handle adbd. Message-ID: 20200605122618.GA359587@linaro.org Content-Type: text/plain; charset="us-ascii"
On Fri, Jun 05, 2020 at 07:06:16AM +0000, Larry Shen wrote:
Hi, Milosz,
Maybe I understand wrong, but I already see there is code like next to add dynamic device node to docker container.
I tried it in manual, adb find devices after a new device node added with next code. But I don't see the docker shell try to call it with some way. What's the aim of next code if you did not want to use it? Could you double confirm internal maybe some guys is handling it, but just in process? Could you do me a favor inform me your plan if my guess is true?
I don't think people could switch from lxc to docker on android if this not support, maybe my environment wrong or anything else?
Yes, you are right. The way the docker test shell currently works won't support such a use case.
First, there was an issue with the udev rules being too strict, which was recently fixed and will be in the next release: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit. lavasoftware.org%2Flava%2Flava%2F-%2Fissues%2F411&data=02%7C01%7Cl arry.shen%40nxp.com%7Ca721328d010d4f6e559208d80b84c9ea%7C686ea1d3bc2b4 c6fa92cd99c5c301635%7C0%7C0%7C637272012232138191&sdata=kLSaQrGCVjw GH%2BGzNSnJjOVCatXl9JKqyL2%2B7R8SsV8%3D&reserved=0
This issue that you mention also needs to be fixed; I created an issue to track and I will work on it: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit. lavasoftware.org%2Flava%2Flava%2F-%2Fissues%2F414&data=02%7C01%7Cl arry.shen%40nxp.com%7Ca721328d010d4f6e559208d80b84c9ea%7C686ea1d3bc2b4 c6fa92cd99c5c301635%7C0%7C0%7C637272012232138191&sdata=i%2BwTn%2BA E7EI%2F2oqlO2xflxn6vZIh1eFelwwBmt7sAkU%3D&reserved=0 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flist s.lavasoftware.org%2Fpipermail%2Flava-users%2Fattachments%2F20200605%2 F741169ba%2Fattachment-0001.sig&data=02%7C01%7Clarry.shen%40nxp.co m%7Ca721328d010d4f6e559208d80b84c9ea%7C686ea1d3bc2b4c6fa92cd99c5c30163 5%7C0%7C0%7C637272012232138191&sdata=ys3%2FNV3kvzMbrIYJ8x2hydvyAnm q1A85pLc9HJK5qF4%3D&reserved=0
Subject: Digest Footer
Lava-users mailing list Lava-users@lists.lavasoftware.org https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist s.lavasoftware.org%2Fmailman%2Flistinfo%2Flava-users&data=02%7C01% 7Clarry.shen%40nxp.com%7Ca721328d010d4f6e559208d80b84c9ea%7C686ea1d3bc 2b4c6fa92cd99c5c301635%7C0%7C0%7C637272012232138191&sdata=Y8S%2BQm WD5xDzd7qj%2BrnqXnviDXBgkP61SjasdlBBiqE%3D&reserved=0
End of Lava-users Digest, Vol 22, Issue 7
Lava-users mailing list Lava-users@lists.lavasoftware.org https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist s.lavasoftware.org%2Fmailman%2Flistinfo%2Flava-users&data=02%7C01% 7Clarry.shen%40nxp.com%7Ca721328d010d4f6e559208d80b84c9ea%7C686ea1d3bc 2b4c6fa92cd99c5c301635%7C0%7C0%7C637272012232138191&sdata=Y8S%2BQm WD5xDzd7qj%2BrnqXnviDXBgkP61SjasdlBBiqE%3D&reserved=0